Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: QR-based add NGRAVE ZERO Hardware #9950

Merged
merged 26 commits into from
Aug 12, 2024
Merged

Conversation

xardass
Copy link
Contributor

@xardass xardass commented Jun 12, 2024

Description

Hello,

This PR changes the UI and text to add the NGRAVE ZERO hardware wallet.

Our upcoming release planned for the beginning of July will add QR code compatibility with MetaMask following EIP-4527.

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/536

See the corresponding changes in the extension: MetaMask/metamask-extension#25080

Manual testing steps

  1. Add a QR based wallet on MetaMask Mobile
  2. Scan the QR code from the hardware wallet.

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jun 12, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@caiquecruz
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

@xardass xardass marked this pull request as ready for review June 12, 2024 20:44
@xardass xardass requested a review from a team as a code owner June 12, 2024 20:44
Akaryatrh
Akaryatrh previously approved these changes Jun 28, 2024
gantunesr
gantunesr previously approved these changes Jul 30, 2024
@gantunesr gantunesr added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jul 31, 2024
@Akaryatrh
Copy link
Contributor

@xardass You PR is approved but there are some conflicts that must be resolved. Can you take care of that so we can proceed with merge? Thanks 🙂

@vivek-consensys vivek-consensys added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 1, 2024
@Akaryatrh Akaryatrh added QA Passed A successful QA run through has been done and removed QA Passed A successful QA run through has been done labels Aug 1, 2024
@caiquecruz caiquecruz dismissed stale reviews from gantunesr and Akaryatrh via 4840e28 August 1, 2024 11:42
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a lint issue because of an unused variable

@caiquecruz
Copy link
Contributor

Looks like there's a lint issue because of an unused variable

Just removed, thank you!

@gantunesr gantunesr added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Aug 1, 2024
@gantunesr
Copy link
Member

@caiquecruz now you need to update the snapshot for that component,

yarn test:unit:update

@Akaryatrh Akaryatrh requested a review from gantunesr August 2, 2024 08:50
@dawnseeker8 dawnseeker8 self-assigned this Aug 12, 2024
@dawnseeker8
Copy link
Contributor

hi, @xardass the PR has been approved by two code reviewer and has qa passed tag. so you can Squash and merge the PR now.

@gantunesr
Copy link
Member

This PR can be merged with a SonarCloud Code Analysis check bypass

@sethkfman sethkfman merged commit b325c28 into MetaMask:main Aug 12, 2024
31 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

9 participants