-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: QR-based add NGRAVE ZERO Hardware #9950
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I have read the CLA Document and I hereby sign the CLA |
@xardass You PR is approved but there are some conflicts that must be resolved. Can you take care of that so we can proceed with merge? Thanks 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a lint issue because of an unused variable
Just removed, thank you! |
@caiquecruz now you need to update the snapshot for that component,
|
hi, @xardass the PR has been approved by two code reviewer and has |
This PR can be merged with a SonarCloud Code Analysis check bypass |
Description
Hello,
This PR changes the UI and text to add the NGRAVE ZERO hardware wallet.
Our upcoming release planned for the beginning of July will add QR code compatibility with MetaMask following EIP-4527.
Related issues
Fixes: https://github.com/MetaMask/accounts-planning/issues/536
See the corresponding changes in the extension: MetaMask/metamask-extension#25080
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist