fix: flakey CI asdf node version

[leotm]

Description

Fix flakey CI
failing on Node v16
instead of using Node v20 (set in: package.json, bitrise.yml, .nvmrc)

$ yarn "setup"

yarn run v1.22.22
error metamask@7.24.0: The engine "node" is incompatible with this module. Expected version "^20.12.2". Got "16.20.2"
error Commands cannot run with an incompatible environment.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Run: provided yarn command failed: exit status 1

TEST_SUITE_FOLDER value is: ./e2e/specs/confirmations/*
TEST_SUITE_TAG value is: .*SmokeConfirmations.*
/root/.asdf/installs/nodejs/16.20.2/lib/node_modules/corepack/dist/lib/corepack.cjs:22762
    throw new Error(
          ^
Error: Error when performing the request to https://registry.npmjs.org/yarn/latest; for troubleshooting help, see https://github.com/nodejs/corepack#troubleshooting
    at fetch (/root/.asdf/installs/nodejs/16.20.2/lib/node_modules/corepack/dist/lib/corepack.cjs:22762:11)
    at async fetchAsJson (/root/.asdf/installs/nodejs/16.20.2/lib/node_modules/corepack/dist/lib/corepack.cjs:22776:20)
    ... 4 lines matching cause stack trace ...
    at async Object.runMain (/root/.asdf/installs/nodejs/16.20.2/lib/node_modules/corepack/dist/lib/corepack.cjs:24232:5) {
  [cause]: TypeError: globalThis.fetch is not a function
      at fetch (/root/.asdf/installs/nodejs/16.20.2/lib/node_modules/corepack/dist/lib/corepack.cjs:22756:33)
      at async fetchAsJson (/root/.asdf/installs/nodejs/16.20.2/lib/node_modules/corepack/dist/lib/corepack.cjs:22776:20)
      at async fetchLatestStableVersion (/root/.asdf/installs/nodejs/16.20.2/lib/node_modules/corepack/dist/lib/corepack.cjs:22703:20)
      at async fetchLatestStableVersion2 (/root/.asdf/installs/nodejs/16.20.2/lib/node_modules/corepack/dist/lib/corepack.cjs:22826:14)
      at async Engine.getDefaultVersion (/root/.asdf/installs/nodejs/16.20.2/lib/node_modules/corepack/dist/lib/corepack.cjs:23433:23)
      at async Engine.executePackageManagerRequest (/root/.asdf/installs/nodejs/16.20.2/lib/node_modules/corepack/dist/lib/corepack.cjs:23525:47)
      at async Object.runMain (/root/.asdf/installs/nodejs/16.20.2/lib/node_modules/corepack/dist/lib/corepack.cjs:24232:5)
}

• remove asdf to setup node
• add bitrise-nvm-step

if flakiness continues, consider removing /root/.asdf/installs/nodejs/16.20.2

Related issues

Fixes: CI

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.17%. Comparing base (b013c71) to head (41c0c14).
Report is 60 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9934      +/-   ##
==========================================
+ Coverage   47.24%   48.17%   +0.92%     
==========================================
  Files        1370     1399      +29     
  Lines       33304    33827     +523     
  Branches     3586     3668      +82     
==========================================
+ Hits        15736    16297     +561     
+ Misses      16607    16523      -84     
- Partials      961     1007      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: bb0ec6a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1df0e3a9-41ea-4aca-b44d-1e8d7e8912c3

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud