Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: align ButtonIcons with design #9899

Merged
merged 11 commits into from
Jun 7, 2024
Merged

chore: align ButtonIcons with design #9899

merged 11 commits into from
Jun 7, 2024

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Jun 6, 2024 •
edited by Cal-L
Loading

Description

This PR updates the ButtonIcon component to align with the ButtonIcon design in Figma.

  • The variants prop has been removed and consolidated with the iconColorOverride prop, allowing developers to configure icon colors more efficiently.
  • A md size has been added to the size prop.
  • All instances of the ButtonIcon component have been updated to reflect these changes.

Related issues

Fixes: #9880

Manual testing steps

Reference videos for examples

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile labels Jun 6, 2024
@brianacnguyen brianacnguyen self-assigned this Jun 6, 2024
@brianacnguyen brianacnguyen requested review from a team as code owners June 6, 2024 19:56
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

georgewrmarshall
georgewrmarshall previously approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • Checked for instances of removed iconColorOverride and ButtonIconVariants ✅

@Cal-L Cal-L added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jun 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 84c6cb4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a698ddef-27bb-4402-b15f-92afbf1c5652

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Cal-L
Cal-L previously approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianacnguyen brianacnguyen dismissed stale reviews from Cal-L and georgewrmarshall via aec2c4a June 7, 2024 20:09
@brianacnguyen brianacnguyen added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: aec2c4a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1a1bab3a-6cdd-4b98-a42d-ac6e848cef46

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@brianacnguyen brianacnguyen added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 16131f6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5403b060-7486-49a3-a4e1-16a36fa0cd26

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
77.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@brianacnguyen brianacnguyen added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 7, 2024
@brianacnguyen brianacnguyen merged commit cd4435a into main Jun 7, 2024
43 checks passed
@brianacnguyen brianacnguyen deleted the buttons-icons-v4 branch June 7, 2024 22:03
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
@metamaskbot metamaskbot added the release-7.26.0 Issue or pull request that will be included in release 7.26.0 label Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

@Cal-L Cal-L Cal-L left review comments

Assignees

@brianacnguyen brianacnguyen

Labels
release-7.26.0 Issue or pull request that will be included in release 7.26.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-design-system All issues relating to design system in Mobile
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MOB] Align ButtonIcons with design
4 participants
@brianacnguyen @georgewrmarshall @Cal-L @metamaskbot