Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: contributor docs link is not correct in pr template #9893

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

gauthierpetetin
Copy link
Contributor

@gauthierpetetin gauthierpetetin commented Jun 6, 2024

Description

The contributor docs link is not correct in pr template

Related issues

  • None

Manual testing steps

  • None

Screenshots/Recordings

  • None

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gauthierpetetin gauthierpetetin requested a review from a team as a code owner June 6, 2024 16:27
Copy link
Contributor

github-actions bot commented Jun 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gauthierpetetin gauthierpetetin changed the title fix:pr-template contributor docs link is not correct fix:pr template - contributor docs link is not correct Jun 6, 2024
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gauthierpetetin gauthierpetetin changed the title fix:pr template - contributor docs link is not correct fix: contributor docs link is not correct in pr template Jun 6, 2024
Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@gauthierpetetin gauthierpetetin merged commit 11af06f into main Jun 6, 2024
40 of 42 checks passed
@gauthierpetetin gauthierpetetin deleted the fix/contributor-docs-link branch June 6, 2024 16:41
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2024
@metamaskbot metamaskbot added the release-7.25.0 Issue or pull request that will be included in release 7.25.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.25.0 Issue or pull request that will be included in release 7.25.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants