Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick: feat: Add the "Manage in settings" link for the STX Opt In modal, update STX controller version #9864

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

dan437
Copy link
Contributor

@dan437 dan437 commented Jun 5, 2024

Description

Cherry pick of this PR: #9839

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@dan437 dan437 requested a review from a team as a code owner June 5, 2024 16:05
Copy link
Contributor

github-actions bot commented Jun 5, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Jun 5, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/smart-transactions-controller@10.1.1 Transitive: environment, filesystem, network +38 7.99 MB

🚮 Removed packages: npm/@metamask/smart-transactions-controller@10.0.0

View full report↗︎

Copy link

socket-security bot commented Jun 5, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/controller-utils@10.0.0, npm/@metamask/eth-block-tracker@9.0.3, npm/@metamask/eth-json-rpc-middleware@12.1.1, npm/@metamask/gas-fee-controller@15.1.2, npm/@metamask/network-controller@18.1.3, npm/@metamask/nonce-tracker@5.0.0, npm/@metamask/smart-transactions-controller@10.1.1, npm/@metamask/transaction-controller@30.0.0, npm/async-mutex@0.5.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@dan437 dan437 added the team-transactions Transactions team label Jun 5, 2024
Copy link

sonarqubecloud bot commented Jun 5, 2024

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me: this cherry pick matches the original PR.

@dbrans
Copy link
Contributor

dbrans commented Jun 5, 2024

@SocketSecurity ignore-all

@Cal-L says: Expected functionality from @MetaMask packages

@dan437 dan437 merged commit 2b84a9f into release/7.24.0 Jun 5, 2024
30 of 33 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2024
@metamaskbot metamaskbot added the release-7.24.3 Issue or pull request that will be included in release 7.24.3 label Jun 19, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-7.24.3 on PR, as PR was cherry-picked in branch 7.24.3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.24.3 Issue or pull request that will be included in release 7.24.3 team-transactions Transactions team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants