Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updated design-tokens to v4 #9845

Merged
merged 11 commits into from
Jun 12, 2024
Merged

feat: updated design-tokens to v4 #9845

merged 11 commits into from
Jun 12, 2024

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Jun 4, 2024 •
edited
Loading

Description

This PR seeks to update the @metamask/design-tokens repo to v4. All changes noted in the migration doc has been factored in this PR.

Related issues

Fixes: #9807

Manual testing steps

  1. Due to the majority of this PR involves snapshot changes from design token changes, refer to the Screenshots/Recordings section below for main changes

Screenshots/Recordings

Before

After

  1. Switch-related code changes due to brandColors.white000 being replaced with brandColors.white
  1. QR code-related code changes due to brandColors.white000 being replaced with brandColors.white, or brandColors.black000 being replaced with brandColors.black
  1. ButtonIcon component replacement due to disabled colors being deprecated
  1. LedgerConnect changes due to brandColors.white000 being replaced with brandColors.white
  1. AndroidMediaPlayer changes due to brandColors.white000 being replaced with brandColors.white
  1. FiatOnTestnetsFriction changes due to warning.alternative being deprecated. Updated icon to warning.default
  1. SliderButton changes due to primary.shadow being changed to shadow.primary
  1. Overall walkthrough after upgrade
  1. Deprecated tokens search
Screenshot 2024-06-12 at 12 06 36 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added the team-design-system All issues relating to design system in Mobile label Jun 4, 2024
@brianacnguyen brianacnguyen self-assigned this Jun 4, 2024
@brianacnguyen brianacnguyen requested a review from a team as a code owner June 4, 2024 15:47
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brianacnguyen brianacnguyen marked this pull request as draft June 4, 2024 16:43
@socket-security Socket Security
Copy link

socket-security bot commented Jun 8, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/design-tokens@4.0.0 None 0 227 kB metamaskbot

🚮 Removed packages: npm/@metamask/design-tokens@2.0.0

View full report↗︎

@socket-security Socket Security
Copy link

socket-security bot commented Jun 8, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@brianacnguyen brianacnguyen marked this pull request as ready for review June 12, 2024 18:56
@brianacnguyen brianacnguyen requested review from a team as code owners June 12, 2024 18:56
@brianacnguyen brianacnguyen added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 12, 2024
@brianacnguyen
Copy link
Contributor Author

@SocketSecurity ignore npm/@metamask/design-tokens@2.0.0

@brianacnguyen brianacnguyen added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jun 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 12, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d21b2a0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/83ed1477-c995-416d-aeb8-5e59cccdc58c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
6.5% Duplication on New Code

See analysis details on SonarCloud

@brianacnguyen brianacnguyen changed the title feat: updated design-tokens to v4 (draft) feat: updated design-tokens to v4 Jun 12, 2024
georgewrmarshall
georgewrmarshall approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 🪩

  • Checked for no remaining deprecated tokens by running this script ✅

Before

Screenshot 2024-06-12 at 2 56 40 PM

After

Screenshot 2024-06-12 at 2 57 26 PM

Cal-L
Cal-L approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For those reviewing, just filter out the snapshot files

@brianacnguyen brianacnguyen merged commit 33d9d12 into main Jun 12, 2024
39 checks passed
@brianacnguyen brianacnguyen deleted the design-tokens-v4 branch June 12, 2024 22:35
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 12, 2024
@metamaskbot metamaskbot added the release-7.26.0 Issue or pull request that will be included in release 7.26.0 label Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

Assignees

@brianacnguyen brianacnguyen

Labels
release-7.26.0 Issue or pull request that will be included in release 7.26.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-design-system All issues relating to design system in Mobile
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MOB] Update design-tokens package to version 4.0.0
4 participants
@brianacnguyen @georgewrmarshall @Cal-L @metamaskbot