Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update Preferences Controller v^11 #9814

Merged
merged 16 commits into from
Jun 7, 2024
Merged

chore: Update Preferences Controller v^11 #9814

merged 16 commits into from
Jun 7, 2024

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented May 31, 2024 •
edited
Loading

Description

This PR updates preferences controller to v^11

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/1791

Manual testing steps

  1. Go to security and settings
  2. Test display nft media toggle
  3. Test show smart transactions

Screenshots/Recordings

Screen.Recording.2024-05-31.at.15.32.48.mov

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform labels May 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security Socket Security
Copy link

socket-security bot commented May 31, 2024 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/preferences-controller@11.0.0 Transitive: filesystem +7 2.31 MB metamaskbot

View full report↗︎

@tommasini tommasini marked this pull request as ready for review June 4, 2024 18:17
@tommasini tommasini requested a review from a team as a code owner June 4, 2024 18:17
@tommasini tommasini requested a review from a team as a code owner June 4, 2024 18:17
@tommasini tommasini added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jun 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 11d5af7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5afa8dce-f5b9-4d79-803b-da2a91f663b2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jun 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 83b04f0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f452bc3e-1444-4ccf-a093-f3c0e7346908

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tommasini tommasini changed the title chore: Update Preferences Controller v^9 chore: Update Preferences Controller v^11 Jun 6, 2024
Cal-L
Cal-L approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini merged commit 89f7d87 into main Jun 7, 2024
51 checks passed
@tommasini tommasini deleted the chore/1791-update-prefereces-controller-v9 branch June 7, 2024 11:48
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 7, 2024
@metamaskbot metamaskbot added the release-7.25.0 Issue or pull request that will be included in release 7.25.0 label Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

@OGPoyraz OGPoyraz OGPoyraz approved these changes

Assignees
No one assigned
Labels
release-7.25.0 Issue or pull request that will be included in release 7.25.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tommasini @OGPoyraz @Cal-L @metamaskbot