Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e builds #9773

Merged
merged 2 commits into from
May 28, 2024
Merged

fix: e2e builds #9773

merged 2 commits into from
May 28, 2024

Conversation

sethkfman
Copy link
Contributor

Description

This PR upgrades the Ruby version to be compatible with E2E test machines.

Related issues

Fixes: NA

Manual testing steps

  1. NA

Screenshots/Recordings

NA

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman changed the base branch from main to release/7.23.0 May 28, 2024 18:33
@sethkfman sethkfman added the Run Smoke E2E Triggers smoke e2e on Bitrise label May 28, 2024
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

github-actions bot commented May 28, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ae4ec82
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e1935cf9-15e3-42e3-8410-db5911535b23

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sethkfman sethkfman added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 28, 2024
Copy link
Contributor

github-actions bot commented May 28, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b06ec00
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8c1090ac-39e9-40fd-a21e-b817f84e9e40

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sethkfman sethkfman merged commit 7f2be29 into release/7.23.0 May 28, 2024
29 of 30 checks passed
@sethkfman sethkfman deleted the fix/e2e-builds branch May 28, 2024 19:07
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants