-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add MetaMetrics delete on Wallet delete #9768
feat: add MetaMetrics delete on Wallet delete #9768
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple, strait to the point. I like that.
Just one note, you could also have used the useMetrics hook (app/components/hooks/useMetrics/useMetrics.ts). So make sure you are ok wit not using it. It ends being exactly the same, just a matter of code style preference.
Can we try to fix this issue on this PR ? Let me know if it makes sense |
I initially thought to use the hook, but this function |
Added in clearing browser history and cache on wallet delete |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9768 +/- ##
==========================================
- Coverage 47.24% 47.24% -0.01%
==========================================
Files 1370 1370
Lines 33304 33309 +5
Branches 3586 3586
==========================================
+ Hits 15736 15738 +2
- Misses 16607 16610 +3
Partials 961 961 ☔ View full report in Codecov by Sentry. |
It seems we have a small lint issue and we are good to go |
….com:MetaMask/metamask-mobile into fix/1271-delete-metametrics-on-delete-wallet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Awesome work!
Quality Gate passedIssues Measures |
Description
This creates a MetaMetrics deletion task when a user deletes their wallet.
Related issues
Fixes: 1271
Manual testing steps
Screenshots/Recordings
Before
After
roblox-cookies-clear.mp4
Pre-merge author checklist
Pre-merge reviewer checklist