Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Selecting custom ethereum mainnet on fresh install #9742

Merged
merged 1 commit into from
May 28, 2024

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented May 23, 2024

Description

On fresh install, there was an error when the user wanted to change to a custom rpc url of ethereum, because there was no other network configurations to override at that point

Related issues

Fixes:

Manual testing steps

  1. Fresh install
  2. Press change rpc url of ethereum before importing account
  3. write the custom rpc url
  4. add it successfully

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…o a custom rpc url of ethereum, because there was no other network configurations to override at that point
@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels May 23, 2024
@tommasini tommasini requested a review from a team as a code owner May 23, 2024 22:08
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented May 23, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9899331
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1bc201fb-eb61-4670-ba71-4cb3d96f2d74

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

Copy link
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! I guess we should also have a test for this, to prevent future regressions?

@legobeat legobeat requested a review from a team May 23, 2024 23:30
@tommasini tommasini merged commit 6d5dddb into main May 28, 2024
54 checks passed
@tommasini tommasini deleted the fix/error-when-custom-mainnet-selected branch May 28, 2024 10:33
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 28, 2024
@metamaskbot metamaskbot added the release-7.24.0 Issue or pull request that will be included in release 7.24.0 label May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.24.0 Issue or pull request that will be included in release 7.24.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants