Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply string changes from #9565 #9629

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented May 14, 2024

Description

This PR only covers the strings from #9565.

Related issues

Split off from: #9565

Manual testing steps

n/a

Screenshots/Recordings

n/a

Before

n/a

After

n/a

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@infiniteflower infiniteflower marked this pull request as ready for review May 14, 2024 20:38
@infiniteflower infiniteflower requested a review from a team as a code owner May 14, 2024 20:38
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@infiniteflower infiniteflower merged commit 3b1fc28 into main May 14, 2024
44 checks passed
@infiniteflower infiniteflower deleted the feat/smart-tx-strings branch May 14, 2024 20:46
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2024
@metamaskbot metamaskbot added the release-7.24.0 Issue or pull request that will be included in release 7.24.0 label May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.24.0 Issue or pull request that will be included in release 7.24.0 team-swaps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants