test: Fix flakiness caused by the notification permission dialog which caused confirmation test flakiness

[cortisiko]

Description

The purpose of this PR is to address sporadic test flakiness within the confirmations workflow. The test, at times, would timeout because it was unable to log into the app. Sometimes, this would result in long-running confirmation e2e workflows in Bitrise.

What caused the failure?

The approve-custom-erc20.spec.js and approve-default-erc20.spec.js tests assert that the submitted the txn is confirmed before making the test as passed.

The notification dialog appears whenever a successful transaction is made. See below

Unfortunately, the system dialog lingers on the simulator.

Whenever new tests run on the simulator, the system dialog prevents the tests from moving forward. See the below screenshot:

Solution

The solution is to set the notifications permission to true. This will prevent the notification dialog from appearing within the tests. Detox's api allows us to set this permission whenever we launch the app for testing. For the curious minds, please read up more here.

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: daca1d9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cd1f4c78-1034-42cd-8031-15b35f804598

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[Cal-L]

LGTM