Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Upgrade to react-native-svg to 15.2.0 #9595

Merged
merged 4 commits into from
May 10, 2024
Merged

feat: Upgrade to react-native-svg to 15.2.0 #9595

merged 4 commits into from
May 10, 2024

Conversation

MarioAslau
Copy link
Contributor

@MarioAslau MarioAslau commented May 9, 2024 •
edited
Loading

Description

Related issues

Fixes: #9594

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@MarioAslau MarioAslau requested a review from a team as a code owner May 9, 2024 20:18
@MarioAslau MarioAslau self-assigned this May 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@MarioAslau MarioAslau added type-bug Something isn't working Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels May 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a33deb5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/91719728-332b-4c3f-82fb-93bbc898e77e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@MarioAslau MarioAslau requested a review from a team as a code owner May 9, 2024 21:36
@socket-security Socket Security
Copy link

socket-security bot commented May 9, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/react-native-svg@15.2.0 network +1 3.06 MB wolewicki

🚮 Removed packages: npm/react-native-svg@12.1.1

View full report↗︎

@MarioAslau MarioAslau requested review from sethkfman and Cal-L May 9, 2024 21:37
@MarioAslau MarioAslau added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f072878
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2f8480f7-325e-46b0-8724-8a4424be7eff

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini
Copy link
Contributor

All the snapshots must be updated because the fill property started to receive options, as it says on this PR

@tommasini
update patch with information of why the fetchText function needed to…
1034f5b 
… change, updated snapshots, and removed part of the patch that seems to not be necessary anymore
@MarioAslau MarioAslau requested review from a team as code owners May 10, 2024 12:43
@tommasini
Copy link
Contributor

Second part of the patch removed, because the previous issue no longer happens, this was the PR that introduced it

Screen.Recording.2024-05-10.at.13.41.51.mov

@MarioAslau MarioAslau added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 10, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4301b67
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/071ac5ad-ffaf-4484-8bb1-2a4b1c40e9da

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@MarioAslau MarioAslau merged commit 1c2fc19 into main May 10, 2024
35 checks passed
@MarioAslau MarioAslau deleted the fix/svg-failures-9594 branch May 10, 2024 13:31
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2024
@metamaskbot metamaskbot added the release-7.23.0 Issue or pull request that will be included in release 7.23.0 label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

@sethkfman sethkfman Awaiting requested review from sethkfman

@Cal-L Cal-L Awaiting requested review from Cal-L

Assignees

@MarioAslau MarioAslau

Labels
release-7.23.0 Issue or pull request that will be included in release 7.23.0 Run Smoke E2E Triggers smoke e2e on Bitrise Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-mobile-platform type-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: Expected > (0:1310). If this is valid SVG, it's probably a bug. Please raise an issue
3 participants
@MarioAslau @tommasini @metamaskbot