Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ramp): add useCryptoCurrencies tests #9580

Merged
merged 7 commits into from
Jul 25, 2024
Merged

test(ramp): add useCryptoCurrencies tests #9580

merged 7 commits into from
Jul 25, 2024

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented May 9, 2024

Description

This PR adds tests for the useCryptoCurrencies hook in Ramp folder.

Related issues

Fixes: N/A

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features Run Smoke E2E Triggers smoke e2e on Bitrise labels May 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 03fd842
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1a959593-c55a-47ec-a535-41840477f811

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@wachunei wachunei marked this pull request as ready for review May 9, 2024 02:11
@wachunei wachunei requested review from a team as code owners May 9, 2024 02:11
@wachunei wachunei force-pushed the test/ramp-use-crypto-currencies branch from 03fd842 to 31c44f9 Compare May 9, 2024 02:40
@wachunei wachunei added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 31c44f9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5b4ed8a2-a206-4882-a69b-2e27d9b77ade

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@wachunei wachunei removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Jun 19, 2024
@wachunei wachunei added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jun 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 19, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8b0908b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ef6a2860-73c0-4a25-8a6e-76660b8a1ff0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@wachunei wachunei removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Jul 23, 2024
@georgeweiler
Copy link
Contributor

I left a comment about DRY'ing up some of the code in the fiat currencies test here: #9582 (comment)

I think a similar suggestion could work on this test. Perhaps they could share the same mocking function?

georgeweiler
georgeweiler approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@georgeweiler georgeweiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a refactor suggestion to consider.

@wachunei wachunei added Run Smoke E2E Triggers smoke e2e on Bitrise and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jul 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 25, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6513687
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/11156678-9c24-4f58-bb17-493c432f9765

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@wachunei wachunei merged commit 0f2f935 into main Jul 25, 2024
38 checks passed
@wachunei wachunei deleted the test/ramp-use-crypto-currencies branch July 25, 2024 18:01
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
@metamaskbot metamaskbot added the release-7.29.0 Issue or pull request that will be included in release 7.29.0 label Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@georgeweiler georgeweiler georgeweiler approved these changes

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.29.0 Issue or pull request that will be included in release 7.29.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-ramp issues related to Ramp features
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wachunei @georgeweiler @metamaskbot