Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add palm to popular network #9431

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Apr 29, 2024

Description

Add Palm network on the popular list

Related issues

Fixes:

Manual testing steps

  1. Go to the popular network list
  2. You should see Palm network on the list

Screenshots/Recordings

Before

Screenshot 2024-04-29 at 10 58 37

After

Screenshot 2024-04-29 at 10 51 27

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb requested a review from a team as a code owner April 29, 2024 08:30
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Apr 29, 2024
@salimtb salimtb force-pushed the add-palm-to-popular-network branch from 1db8d35 to 32c1464 Compare April 29, 2024 08:32
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
100.0% Duplication on New Code

See analysis details on SonarCloud

@salimtb salimtb added the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 29, 2024
Copy link
Contributor

github-actions bot commented Apr 29, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 32c1464
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/74b1dac2-4d41-40fd-a95c-f77256445797

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb merged commit 1981751 into main Apr 29, 2024
37 checks passed
@salimtb salimtb deleted the add-palm-to-popular-network branch April 29, 2024 12:15
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
@metamaskbot metamaskbot added the release-7.23.0 Issue or pull request that will be included in release 7.23.0 label Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-7.23.0 Issue or pull request that will be included in release 7.23.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants