Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move NFT import test to quarantine folder #9420

Merged
merged 1 commit into from
Apr 26, 2024
Merged

test: move NFT import test to quarantine folder #9420

merged 1 commit into from
Apr 26, 2024

Conversation

cortisiko
Copy link
Member

Description

A previous PR attempted to fix the NFT import test but as soon as the changes were merged into main the tests started failing. The purpose of this PR is to quarantine the NFT import test.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels Apr 26, 2024
@cortisiko cortisiko self-assigned this Apr 26, 2024
@cortisiko cortisiko requested a review from a team as a code owner April 26, 2024 18:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 26, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0ec093c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bf4b0bcc-6581-486a-90f4-703dbee2998f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

MarioAslau
MarioAslau approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@cortisiko cortisiko merged commit f63a21d into main Apr 26, 2024
40 checks passed
@cortisiko cortisiko deleted the detox/move-nft-to-qurantine-folder branch April 26, 2024 18:58
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
@metamaskbot metamaskbot added the release-7.23.0 Issue or pull request that will be included in release 7.23.0 label Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sleepytanya sleepytanya sleepytanya approved these changes

@MarioAslau MarioAslau MarioAslau approved these changes

Assignees

@cortisiko cortisiko

Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.23.0 Issue or pull request that will be included in release 7.23.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cortisiko @MarioAslau @sleepytanya @metamaskbot