-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ramp): transform aggregator network chain id to string #9415
Conversation
Bitrise✅✅✅ Commit hash: dfe8c63 Note
|
@wachunei LGTM for QA ✅ |
Bitrise✅✅✅ Commit hash: 2506f57 Note
|
Quality Gate passedIssues Measures |
Description
This PR prepares the Ramp codebase for an upcoming change in the Ramp API and Ramp SDK: the
AggregatorNetwork['chainId']
will change from typenumber
tostring
.Places where it was being used as number have been changes to be used as string. Also, we now consider potential errors in places where the
chainId
was being transformed into a Hex string type (`0x${string}`
), for examplechainId
with value"example"
would have been involved intoHex(chainId)
which would have thrown.Once the Ramp API & SDK are updated, the transformation to string must be removed. This label marks the places it was done
TODO(ramp, chainId-string):
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/RAMPS-1559
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist