Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add useFirstPartyContractName hook #9407

Merged
merged 12 commits into from
May 6, 2024
Merged

feat: Add useFirstPartyContractName hook #9407

merged 12 commits into from
May 6, 2024

Conversation

OGPoyraz
Copy link
Member

Description

This PR aims to add useFirstPartyContractNames hook to be added in to useDisplayName

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/1715

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@socket-security Socket Security
Copy link

socket-security bot commented Apr 25, 2024 •
edited
Loading

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@OGPoyraz OGPoyraz changed the title Add useFirstPartyContractName hook Add useFirstPartyContractName hook Apr 25, 2024
@OGPoyraz OGPoyraz changed the title Add useFirstPartyContractName hook feat: Add useFirstPartyContractName hook Apr 25, 2024
@OGPoyraz OGPoyraz added the team-confirmations Push issues to confirmations team label Apr 25, 2024
@OGPoyraz OGPoyraz marked this pull request as ready for review April 30, 2024 08:52
@OGPoyraz OGPoyraz requested review from a team as code owners April 30, 2024 08:52
brianacnguyen
brianacnguyen previously requested changes May 1, 2024
View reviewed changes
Copy link
Contributor

@brianacnguyen brianacnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files belong in the components folder

matthewwalsh0
matthewwalsh0 reviewed May 1, 2024
View reviewed changes
app/constants/first-party-contracts.ts Outdated Show resolved Hide resolved
app/component-library/hooks/useFirstPartyContractName.ts Outdated Show resolved Hide resolved
app/component-library/hooks/useFirstPartyContractName.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@OGPoyraz OGPoyraz dismissed brianacnguyen’s stale review May 2, 2024 11:50

OOO for next day & week

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@OGPoyraz OGPoyraz merged commit f282551 into main May 6, 2024
31 checks passed
@OGPoyraz OGPoyraz deleted the 1715-display-first-party-contract-names-in-name-component branch May 6, 2024 06:38
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2024
@metamaskbot metamaskbot added the release-7.23.0 Issue or pull request that will be included in release 7.23.0 label May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

@brianacnguyen brianacnguyen brianacnguyen left review comments

Assignees
No one assigned
Labels
release-7.23.0 Issue or pull request that will be included in release 7.23.0 team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OGPoyraz @brianacnguyen @matthewwalsh0 @metamaskbot