Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: translations for fiat testnet toggle #9361

Merged
merged 2 commits into from
Apr 24, 2024
Merged

feat: translations for fiat testnet toggle #9361

merged 2 commits into from
Apr 24, 2024

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented Apr 22, 2024 •
edited
Loading

Description

Translations for #9129

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bergeron bergeron requested a review from a team as a code owner April 22, 2024 20:41
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bergeron bergeron added area-translation For Blendin translation. team-assets labels Apr 22, 2024
@bergeron bergeron mentioned this pull request Apr 22, 2024
Merged
7 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@bergeron bergeron requested review from sahar-fehri and salimtb April 22, 2024 21:12
@bergeron bergeron added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Apr 22, 2024
sethkfman
sethkfman approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bergeron bergeron merged commit 2d195e2 into main Apr 24, 2024
35 checks passed
@bergeron bergeron deleted the brian/fiat-toggle-translations branch April 24, 2024 15:55
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
@gauthierpetetin gauthierpetetin added release-7.22.0 Issue or pull request that will be included in release 7.22.0 and removed release-7.28.0 labels Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@salimtb salimtb salimtb approved these changes

@sahar-fehri sahar-fehri sahar-fehri approved these changes

@sethkfman sethkfman sethkfman approved these changes

Assignees
No one assigned
Labels
area-translation For Blendin translation. needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-7.22.0 Issue or pull request that will be included in release 7.22.0 team-assets
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bergeron @sethkfman @sahar-fehri @salimtb @gauthierpetetin @metamaskbot