Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid url on inapp-browser #9284

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix: invalid url on inapp-browser #9284

merged 1 commit into from
Apr 17, 2024

Conversation

abretonc7s
Copy link
Contributor

Description

Invalid url when using in-app browser.

Related issues

Fixes: #9259

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@abretonc7s abretonc7s self-assigned this Apr 17, 2024
@abretonc7s abretonc7s marked this pull request as ready for review April 17, 2024 12:44
@abretonc7s abretonc7s requested a review from a team as a code owner April 17, 2024 12:44
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@christopherferreira9 christopherferreira9 added QA Passed A successful QA run through has been done team-sdk SDK team labels Apr 17, 2024
@christopherferreira9
Copy link
Contributor

Test case: steps from #9259

Video.from.GitHub.mov

@christopherferreira9 christopherferreira9 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 17, 2024
Copy link
Contributor

github-actions bot commented Apr 17, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e9daf7f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/67d0f4a3-d742-4945-b8bc-c7a314ad6f4b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@christopherferreira9 christopherferreira9 merged commit 191456d into main Apr 17, 2024
40 of 41 checks passed
@christopherferreira9 christopherferreira9 deleted the fix/wc-9259 branch April 17, 2024 14:55
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2024
@metamaskbot metamaskbot added release-7.22.0 Issue or pull request that will be included in release 7.22.0 release-7.21.0 Issue or pull request that will be included in release 7.21.0 and removed release-7.22.0 Issue or pull request that will be included in release 7.22.0 labels Apr 17, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-7.21.0 on PR. Adding release label release-7.21.0 on PR and removing other release labels(release-7.22.0), as PR was cherry-picked in branch 7.21.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done release-7.21.0 Issue or pull request that will be included in release 7.21.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-sdk SDK team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Connection Modal - Incorrect URL displayed in the Connectg Account modal when using the in-browser
4 participants