Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update readme #9192

Merged
merged 1 commit into from
Apr 12, 2024
Merged

chore: update readme #9192

merged 1 commit into from
Apr 12, 2024

Conversation

pnarayanaswamy
Copy link
Contributor

Description

Update the read me to include the correct path to Android SDK

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pnarayanaswamy pnarayanaswamy added the team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead label Apr 10, 2024
@pnarayanaswamy pnarayanaswamy requested a review from a team as a code owner April 10, 2024 14:22
Copy link
Contributor

github-actions bot commented Apr 10, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@pnarayanaswamy
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@gauthierpetetin gauthierpetetin added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 11, 2024
@pnarayanaswamy pnarayanaswamy merged commit 51eabfa into main Apr 12, 2024
38 checks passed
@pnarayanaswamy pnarayanaswamy deleted the fix_readme branch April 12, 2024 10:48
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 12, 2024
@metamaskbot metamaskbot added the release-7.22.0 Issue or pull request that will be included in release 7.22.0 label Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.22.0 Issue or pull request that will be included in release 7.22.0 team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants