-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix secrets for tenderly #9106
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9106 +/- ##
=======================================
Coverage 45.35% 45.35%
=======================================
Files 1272 1272
Lines 31247 31247
Branches 3189 3189
=======================================
Hits 14171 14171
Misses 16234 16234
Partials 842 842 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
Bitrise✅✅✅ Commit hash: a68ebdc Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
The RPC URL for the testnet used in swaps was incorrect, and as a result, the tests failed because they could not connect to the network.
process.env.TENDERLY_NETWORK_ID
was returning undefined. This PR assignsprocess.env.TENDERLY_NETWORK_ID
to a variable before using it in the testnet RPC url. It fixes the issue locally.Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist