Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove duplicate i18n, en key: qr_hardware #9051

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Mar 25, 2024

Description

Removes duplicate en, i18n key: qr_hardware

Related issues

Fixes:

Manual testing steps

Screenshots/Recordings

Before

Screenshot 2024-03-25 at 3 15 43 PM

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested a review from a team as a code owner March 25, 2024 22:17
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.58%. Comparing base (c3646ff) to head (d588170).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9051   +/-   ##
=======================================
  Coverage   45.58%   45.58%           
=======================================
  Files        1276     1276           
  Lines       31302    31302           
  Branches     3202     3202           
=======================================
+ Hits        14269    14270    +1     
+ Misses      16187    16186    -1     
  Partials      846      846           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 1 minor comment is to fix the PR label to pass the CI

@digiwand digiwand added the team-confirmations-secure-ux-PR PR from the confirmations team label Mar 26, 2024
@digiwand digiwand merged commit 0f7f117 into main Mar 26, 2024
41 of 42 checks passed
@digiwand digiwand deleted the fix-remove-duplicate-qr_hardware-i18n-key branch March 26, 2024 14:51
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2024
@metamaskbot metamaskbot added the release-7.20.0 Issue or pull request that will be included in release 7.20.0 label Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.20.0 Issue or pull request that will be included in release 7.20.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants