Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend blockaid validations to base network #9030

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Mar 22, 2024

Description

Extend support fof blcokaid validations to base network.

Related issues

Fixes: MetaMask/MetaMask-planning#2078

Manual testing steps

  1. Add base network and switch to it
  2. Submit transactions from test dapp
  3. Transactions should be validated as expected

Screenshots/Recordings

Screenshot 2024-03-22 at 3 49 42 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team labels Mar 22, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Base automatically changed from ppom_version_update to main March 27, 2024 10:36
@jpuri jpuri force-pushed the blockaid_base_network branch from f921caa to e338a04 Compare April 16, 2024 02:07
@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Apr 16, 2024
@jpuri jpuri marked this pull request as ready for review April 16, 2024 02:07
@jpuri jpuri requested a review from a team as a code owner April 16, 2024 02:07
Copy link
Contributor

github-actions bot commented Apr 16, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e338a04
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/be804cb2-1a39-49d9-9352-1c38186acaf3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jpuri jpuri merged commit 420defa into main Apr 17, 2024
34 checks passed
@jpuri jpuri deleted the blockaid_base_network branch April 17, 2024 12:46
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 17, 2024
@metamaskbot metamaskbot added the release-7.22.0 Issue or pull request that will be included in release 7.22.0 label Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.22.0 Issue or pull request that will be included in release 7.22.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations-secure-ux-PR PR from the confirmations team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants