test: 1453 refactor modal pages batch 3

[SamuelSalas]

Description

We are aiming to refactor the page objects in the modal folder so that they strictly follow the page object model pattern. This would aide in providing more readable and help standardize the way we create our tests. Because of the amount of files inside of the modal folder, the scope was divided into a batch of 4.

Files inside the scope for this batch:

• NetworkEducationModal.js
• NetworkListModal.js
• OnboardingWizardModal.js
• ProtectYourWalletModal.js
• RequestPaymentModal.js

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Regression test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a21ca4f5-9020-47e1-9b2b-97b49d4b5ddd

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.26%. Comparing base (2c0d6ce) to head (671be38).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8909   +/-   ##
=======================================
  Coverage   43.26%   43.26%           
=======================================
  Files        1271     1271           
  Lines       30921    30921           
  Branches     3092     3092           
=======================================
  Hits        13379    13379           
  Misses      16769    16769           
  Partials      773      773           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cortisiko]

@SamuelSalas I left a follow up comment. Also there are merge conflicts on your PR. Will move it back to dev in progress

[cortisiko]

✅ ✅ ✅

[SamuelSalas]

Latest bitrise test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a21ca4f5-9020-47e1-9b2b-97b49d4b5ddd

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud