-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: type for auth events and typo #8861
Conversation
fix typo
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise❌❌❌ Commit hash: 5255cba Note
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Could you provide a screenshot in Segment, I don't think we have access yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
More than one release label on PR. Keeping the lowest one (release-7.18.0) on PR and removing other release labels (release-7.19.0). |
Description
Related issues
Fixes #8860
Manual testing steps
the identify event should be like the following with
"Authentication Type": "password",
:"[object Object]": "password"
:Screenshots/Recordings
NA
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist