-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Move Security settings from Experimental Settings into Security Settings #8635
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
09ad679
to
163807d
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8635 +/- ##
=======================================
Coverage 41.43% 41.44%
=======================================
Files 1254 1256 +2
Lines 30565 30571 +6
Branches 3001 3001
=======================================
+ Hits 12666 12671 +5
- Misses 17146 17147 +1
Partials 753 753 ☔ View full report in Codecov by Sentry. |
app/components/Views/Settings/SecuritySettings/Sections/BlockaidSettings.tsx
Show resolved
Hide resolved
Other than this, it looks good to me 🔥 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Move blockaid settings under reveal private key settings. Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com> Fix snapshot. Fix switch styles
401f45c
to
7acab10
Compare
app/components/Views/Settings/SecuritySettings/Sections/BlockaidSettings.tsx
Outdated
Show resolved
Hide resolved
app/components/Views/Settings/SecuritySettings/Sections/BlockaidSettings.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change i18n name Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
Quality Gate passedIssues Measures |
Description
We should move security alerts feature out of Settings > Experimental to Settings > Security & Privacy under the Security section below the show private key feature.
Related issues
Fixes: #1986
Manual testing steps
Screenshots/Recordings
Before
before_move_mobile.mov
After
after_move_mobile.mov
Pre-merge author checklist
Pre-merge reviewer checklist