Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move Security settings from Experimental Settings into Security Settings #8635

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

segun
Copy link
Contributor

@segun segun commented Feb 20, 2024

Description

We should move security alerts feature out of Settings > Experimental to Settings > Security & Privacy under the Security section below the show private key feature.

Related issues

Fixes: #1986

Manual testing steps

  1. Start Metamask
  2. Open Settings > Experimental and see blockaid settings
  3. Checkout this branch
  4. Open Metamask
  5. Open Settings > Security & Privacy and see blockaid settings under private key settings

Screenshots/Recordings

Before

before_move_mobile.mov

After

after_move_mobile.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@segun segun added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team labels Feb 20, 2024
@segun segun self-assigned this Feb 20, 2024
@segun segun requested a review from a team as a code owner February 20, 2024 13:42
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@segun segun force-pushed the olu/move-security-settings branch from 09ad679 to 163807d Compare February 20, 2024 13:45
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (9d6f8ee) 41.43% compared to head (cf74584) 41.44%.
Report is 2 commits behind head on main.

Files Patch % Lines
...ngs/SecuritySettings/Sections/BlockaidSettings.tsx 50.00% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8635   +/-   ##
=======================================
  Coverage   41.43%   41.44%           
=======================================
  Files        1254     1256    +2     
  Lines       30565    30571    +6     
  Branches     3001     3001           
=======================================
+ Hits        12666    12671    +5     
- Misses      17146    17147    +1     
  Partials      753      753           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackdevelopa
Copy link
Contributor

blackdevelopa commented Feb 20, 2024

Other than this, it looks good to me 🔥

jpuri
jpuri previously approved these changes Feb 20, 2024
Copy link
Contributor

@jpuri jpuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

Move blockaid settings under reveal private key settings.

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>

Fix snapshot.

Fix switch styles
@segun segun force-pushed the olu/move-security-settings branch from 401f45c to 7acab10 Compare February 20, 2024 16:00
jpuri
jpuri previously approved these changes Feb 20, 2024
@blackdevelopa blackdevelopa self-requested a review February 20, 2024 17:19
blackdevelopa
blackdevelopa previously approved these changes Feb 20, 2024
Copy link
Contributor

@digiwand digiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for consistency, I think we should update the toggle button to be right-aligned with content on the left

current:
Screenshot 2024-02-20 at 10 28 31 AM

example of other existing toggle settings:
Screenshot 2024-02-20 at 10 28 02 AM
Screenshot 2024-02-20 at 10 28 15 AM

Change i18n name

Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
@segun segun dismissed stale reviews from blackdevelopa and jpuri via cf74584 February 21, 2024 06:06
Copy link

@segun segun merged commit bb1eb2f into main Feb 23, 2024
28 checks passed
@segun segun deleted the olu/move-security-settings branch February 23, 2024 13:20
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 23, 2024
@metamaskbot metamaskbot added the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.18.0 Issue or pull request that will be included in release 7.18.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants