Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace SheetBottom with BottomSheet in SDKFeedbackModal #8445

Merged
merged 3 commits into from
Jan 30, 2024
+10 −8
Merged

refactor: Replace SheetBottom with BottomSheet in SDKFeedbackModal #8445

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5c0c57
Replaced SheetBottom with BottomSheet in SDKFeedbackModal
brianacnguyen Jan 29, 2024
83af9eb
Merge branch 'main' of https://github.com/MetaMask/metamask-mobile in…
brianacnguyen Jan 30, 2024
91b2e8a
Updated ref usage
brianacnguyen Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions app/components/Views/SDKFeedbackModal/SDKFeedbackModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,23 @@
import SDKFeedback from '../../../../app/components/UI/SDKFeedback';
// Third party dependencies
import React, { useRef } from 'react';

import SheetBottom, {
SheetBottomRef,
} from '../../../component-library/components/Sheet/SheetBottom';
// External dependencies
import SDKFeedback from '../../../components/UI/SDKFeedback';
brianacnguyen marked this conversation as resolved.
Show resolved Hide resolved
import BottomSheet, {
BottomSheetRef,
} from '../../../component-library/components/BottomSheets/BottomSheet';

const SDKLoadingModal = () => {
const sheetRef = useRef<SheetBottomRef>(null);
const sheetRef = useRef<BottomSheetRef>(null);

return (
<SheetBottom ref={sheetRef}>
<BottomSheet ref={sheetRef}>
<SDKFeedback
onConfirm={() => {
sheetRef.current?.hide();
sheetRef.current?.onCloseBottomSheet();
}}
/>
</SheetBottom>
</BottomSheet>
);
};

Expand Down
Loading