test: fix Swap test flakiness on Bitrise

[davibroc]

Description

I removed the second swipe to swap action as it wasn't needed anymore and was causing flakiness.

I did 3 regression runs to verify the fix and all passed:
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/50693ba2-3e80-4b0f-a818-572e4a908a9f
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cf8434dd-5da5-444e-9c1b-0e12221f2626
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0e16e1ad-5380-4b3f-8a5d-f2a8078d2cd7

Also ran with 3 workers locally. See video of the run here
https://drive.google.com/file/d/1iu-ZceegN1z0BWoix2KsHz-_1Y-xVK8Z/view?usp=sharing

Related issues

Fixes: #8340

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (afcaa91) 40.30% compared to head (c6e57cb) 40.30%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8342   +/-   ##
=======================================
  Coverage   40.30%   40.30%           
=======================================
  Files        1235     1235           
  Lines       29928    29928           
  Branches     2872     2872           
=======================================
  Hits        12062    12062           
  Misses      17173    17173           
  Partials      693      693           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Andepande]

LGTM Bitrise run is consistent too

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[cortisiko]

🌮🌮🌮🌮

[metamaskbot]

Missing release label release-7.15.0 on PR. Adding release label release-7.15.0 on PR and removing other release labels(release-7.16.0), as PR was cherry-picked in branch 7.15.0.