Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ramp): add useActivationKeys hook test #8138

Merged
merged 7 commits into from
May 7, 2024

Conversation

wachunei
Copy link
Member

Description

This PR adds test for the useActionKeys hook. It also refactors the default values from the hook options since they were defaulting to undefined instead of false

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features labels Dec 16, 2023
@wachunei wachunei force-pushed the chore/ramp-use-activation-keys-hook-test branch from 5b7e342 to 6027bfb Compare May 6, 2024 15:57
@wachunei wachunei force-pushed the chore/ramp-use-activation-keys-hook-test branch from 6027bfb to 1e6cf12 Compare May 6, 2024 15:57
Copy link

sonarqubecloud bot commented May 6, 2024

@wachunei wachunei added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise and removed No QA Needed Apply this label when your PR does not need any QA effort. labels May 6, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1e6cf12
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/930f0887-c21a-4134-b3e6-acc004690215

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@wachunei wachunei marked this pull request as ready for review May 6, 2024 17:49
@wachunei wachunei requested review from a team as code owners May 6, 2024 17:49
@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 7, 2024
@wachunei wachunei merged commit c41caef into main May 7, 2024
39 checks passed
@wachunei wachunei deleted the chore/ramp-use-activation-keys-hook-test branch May 7, 2024 21:13
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2024
@metamaskbot metamaskbot added the release-7.23.0 Issue or pull request that will be included in release 7.23.0 label May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.23.0 Issue or pull request that will be included in release 7.23.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-ramp issues related to Ramp features
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants