-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(ramp): add useActivationKeys hook test #8138
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachunei
added
No QA Needed
Apply this label when your PR does not need any QA effort.
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
team-ramp
issues related to Ramp features
labels
Dec 16, 2023
9 tasks
wachunei
force-pushed
the
chore/ramp-use-activation-keys-hook-test
branch
from
May 6, 2024 15:57
5b7e342
to
6027bfb
Compare
wachunei
force-pushed
the
chore/ramp-use-activation-keys-hook-test
branch
from
May 6, 2024 15:57
6027bfb
to
1e6cf12
Compare
Quality Gate passedIssues Measures |
wachunei
added
No QA Needed
Apply this label when your PR does not need any QA effort.
Run Smoke E2E
Triggers smoke e2e on Bitrise
and removed
No QA Needed
Apply this label when your PR does not need any QA effort.
labels
May 6, 2024
Bitrise✅✅✅ Commit hash: 1e6cf12 Note
|
georgeweiler
approved these changes
May 7, 2024
wachunei
removed
the
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
label
May 7, 2024
metamaskbot
added
the
release-7.23.0
Issue or pull request that will be included in release 7.23.0
label
May 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
No QA Needed
Apply this label when your PR does not need any QA effort.
release-7.23.0
Issue or pull request that will be included in release 7.23.0
Run Smoke E2E
Triggers smoke e2e on Bitrise
team-ramp
issues related to Ramp features
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds test for the
useActionKeys
hook. It also refactors the default values from the hook options since they were defaulting toundefined
instead of falseRelated issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist