Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve web3 provider injection #8130

Conversation

jpcloureiro
Copy link
Contributor

@jpcloureiro jpcloureiro commented Dec 15, 2023

Description

This is part of the Mobile Browser upgrade patch series.

More information under mm-planning

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpcloureiro jpcloureiro force-pushed the react-native-webview-patches/improve-web3-provider-injection branch from 959c9a2 to f49520a Compare December 15, 2023 17:21
@jpcloureiro jpcloureiro force-pushed the react-native-webview-patches/improve-web3-provider-injection branch from 5d9c76f to 6f3bfe2 Compare December 15, 2023 22:46
@jpcloureiro jpcloureiro force-pushed the react-native-webview-patches/improve-web3-provider-injection branch from 840ac78 to b63f32e Compare January 11, 2024 13:04
@jpcloureiro jpcloureiro marked this pull request as ready for review January 16, 2024 11:20
@jpcloureiro jpcloureiro requested a review from a team as a code owner January 16, 2024 11:20
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5dfc92bc-2192-4f3f-8bf3-9e92a4c9336c
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@jpcloureiro jpcloureiro changed the title improve web3 provider injection on Android [RNWebview upgrade] improve web3 provider injection Jan 16, 2024
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good ✅

@cortisiko cortisiko added the QA Passed A successful QA run through has been done label Jan 27, 2024
@jpcloureiro jpcloureiro changed the title [RNWebview upgrade] improve web3 provider injection Improve web3 provider injection Jan 29, 2024
@jpcloureiro jpcloureiro force-pushed the react-native-webview-patches/improve-web3-provider-injection branch from 9e9b162 to e479d2d Compare February 1, 2024 15:43
Copy link

sonarqubecloud bot commented Feb 1, 2024

@jpcloureiro jpcloureiro merged commit a5381ca into upgrade/react-native-webview Feb 1, 2024
25 checks passed
@jpcloureiro jpcloureiro deleted the react-native-webview-patches/improve-web3-provider-injection branch February 1, 2024 16:00
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done RNWebView team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants