-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: CI flakey unit tests TypeErrors on react-native/jest/setup.js global.performance #8046
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
some unit tests passing now: 6/9/10 in f3ea456 |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/72b88636-8bdd-427a-83f3-eb4b5c648f26 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8046 +/- ##
=======================================
Coverage 37.06% 37.06%
=======================================
Files 1135 1135
Lines 29150 29150
Branches 2728 2728
=======================================
Hits 10803 10803
Misses 17724 17724
Partials 623 623 ☔ View full report in Codecov by Sentry. |
This reverts commit 4c84c91.
just when appeared fixed in 4711633 ✅ CI passing the last 2 commits resulting in no change indicate something else is flakey TBC |
converted back to draft until CI flakiness resolved
so node's perf API global prop writable descriptor is defined (not in node v18.19.0) consider bumping jest monorepo devDeps to nb: the flakey TypeError is unrelated to SES |
I.e. don't use Node v18.19, since global.performance's writable descriptor isn't defined
I.e. don't use Node v18.19, since global.performance's writable descriptor isn't defined (No need for "v" prefix: https://github.com/nvm-sh/nvm#nvmrc)
a162985
to
794e6bb
Compare
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/16c6de0b-876a-47d6-9759-8531d9e8321b |
can confirm CI breaking on Node 18.19.0 passing on 18.18.2 final minimal solution: RN patch reverted, Node vers restricted so CI no longer flakey future consideration: upgrading to 18.19+ likely requires bumping jest and/or RN as mentioned above |
ab43449
to
10794b1
Compare
Kudos, SonarCloud Quality Gate passed! |
unit tests passing, Bitrise E2E git clones failing re-running failed jobs w remote access |
|
Description
Fix recent CI flakey failing unit tests:
TypeError: Cannot assign to read only property 'performance' of object '[object global]'
Failing at: https://github.com/facebook/react-native/blob/v0.71.14/jest/setup.js#L20-L22
Nb: https://github.com/facebook/react-native/blob/v0.72.0/jest/setup.js 404 file no longer exists in this future RN ver
Reconsider current node/jest/RN vers we're using (see issue and comment below)
Nb: Node 18.19 changelog
Related issues
Fixes: #8051
Manual testing steps
Run unit tests
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist