Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: batch 1 remove strings testid app code #8011

Merged
merged 10 commits into from
Dec 5, 2023

Conversation

SamuelSalas
Copy link
Contributor

@SamuelSalas SamuelSalas commented Dec 5, 2023

Description

Replace all string definitions used for testIDs. These files should no longer selector strings in the TestID prop:

  • app/component-library/components/Icons/Icon/Icon.test.tsx
  • app/components/UI/AccountOverview/index.js
  • app/components/UI/AccountRightButton/index.tsx
  • app/components/UI/AddCustomCollectible/index.tsx
  • app/components/UI/AddressInputs/index.js
  • app/components/UI/ApproveTransactionReview/index.js
  • app/components/UI/AssetList/index.js

Related issues

Fixes: 7865

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, please run regression and smoke.

app/components/UI/AssetList/index.js Outdated Show resolved Hide resolved
app/components/UI/ApproveTransactionReview/index.js Outdated Show resolved Hide resolved
app/components/UI/ApproveTransactionReview/index.js Outdated Show resolved Hide resolved
@cortisiko cortisiko added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Dec 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (cbaa4bc) 36.61% compared to head (bc22cd9) 36.61%.

Files Patch % Lines
...pp/components/UI/ApproveTransactionReview/index.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8011   +/-   ##
=======================================
  Coverage   36.61%   36.61%           
=======================================
  Files        1120     1120           
  Lines       29196    29196           
  Branches     2720     2720           
=======================================
  Hits        10691    10691           
  Misses      17893    17893           
  Partials      612      612           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelSalas SamuelSalas requested a review from cortisiko December 5, 2023 20:00
@metamaskbot metamaskbot added in-progress and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Dec 5, 2023
Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SamuelSalas SamuelSalas merged commit 2377e2f into main Dec 5, 2023
26 checks passed
@SamuelSalas SamuelSalas deleted the test/7865-batch-1-remove-strings-testid-app-code branch December 5, 2023 21:49
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
@metamaskbot metamaskbot added the release-7.14.0 Issue or pull request that will be included in release 7.14.0 label Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.14.0 Issue or pull request that will be included in release 7.14.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Batch 1/7] Remove all instances of strings in TestID property in the app code
5 participants