Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update header key #8007

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Dec 5, 2023

Description

Update the header key for the Coingecko API call.

  • Request from Coingecko to have the header value be: X-Requested-With: metamask.dec.jan.2024

Related issues

Fixes:

Manual testing steps

  1. Navigate to wallet view
  2. Have two accounts with multiple tokens
  3. Switch between accounts and confirm fiat balances display

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sethkfman sethkfman requested a review from a team as a code owner December 5, 2023 15:43
@sethkfman sethkfman added release-7.12.1 Issue or pull request that will be included in release 7.12.1 team-mobile-client labels Dec 5, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/7.12.1@2e9430e). Click here to learn what that means.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/7.12.1    #8007   +/-   ##
=================================================
  Coverage                  ?   37.38%           
=================================================
  Files                     ?     1052           
  Lines                     ?    28172           
  Branches                  ?     2517           
=================================================
  Hits                      ?    10533           
  Misses                    ?    17040           
  Partials                  ?      599           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sethkfman sethkfman merged commit 1ea9eb1 into release/7.12.1 Dec 5, 2023
31 checks passed
@sethkfman sethkfman deleted the chore/update-header-key branch December 5, 2023 16:21
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.12.1 Issue or pull request that will be included in release 7.12.1 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants