Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mobile blockaid performance issues #8004

Merged
merged 2 commits into from
Dec 7, 2023
Merged

fix: mobile blockaid performance issues #8004

merged 2 commits into from
Dec 7, 2023

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Dec 5, 2023

Description

PPOM validator update with performance optimisations.

Related issues

MetaMask/MetaMask-planning#1701

Manual testing steps

  1. Enable blockaid
  2. To to test dapp and submit malicious transaction
  3. It should work as expected and show validation error

Screenshots/Recordings

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team labels Dec 5, 2023
Copy link
Contributor

github-actions bot commented Dec 5, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri changed the title Update PPOM validator fix: mobile blockaid performance issues Dec 5, 2023
@jpuri jpuri marked this pull request as ready for review December 5, 2023 11:21
@jpuri jpuri requested a review from a team as a code owner December 5, 2023 11:21
Copy link
Contributor

github-actions bot commented Dec 5, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/37bd43ba-3faf-4b45-b8df-ca91dcb667f6
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bbfc340) 36.59% compared to head (b6d42ed) 36.47%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8004      +/-   ##
==========================================
- Coverage   36.59%   36.47%   -0.13%     
==========================================
  Files        1120     1119       -1     
  Lines       29188    29093      -95     
  Branches     2717     2721       +4     
==========================================
- Hits        10682    10611      -71     
+ Misses      17894    17870      -24     
  Partials      612      612              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

socket-security bot commented Dec 5, 2023

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/ppom-validator 0.11.0...0.13.0 None +0/-0 147 kB

Copy link

socket-security bot commented Dec 5, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @metamask/ppom-validator@0.13.0

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

cryptotavares
cryptotavares previously approved these changes Dec 5, 2023
blackdevelopa
blackdevelopa previously approved these changes Dec 6, 2023
digiwand
digiwand previously approved these changes Dec 6, 2023
@jpuri jpuri dismissed stale reviews from digiwand, blackdevelopa, and cryptotavares via b6d42ed December 6, 2023 14:46
@jpuri
Copy link
Contributor Author

jpuri commented Dec 6, 2023

@SocketSecurity ignore @metamask/ppom-validator@0.13.0

Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jpuri
Copy link
Contributor Author

jpuri commented Dec 6, 2023

@jpuri jpuri merged commit f6f016d into main Dec 7, 2023
26 checks passed
@jpuri jpuri deleted the validator_update branch December 7, 2023 00:18
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
@metamaskbot metamaskbot added the release-7.14.0 Issue or pull request that will be included in release 7.14.0 label Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.14.0 Issue or pull request that will be included in release 7.14.0 team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants