-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Removing test selector strings within app code (5/7) #7989
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a1bcac1b-a9af-40ac-b13d-276a9f498a6d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
We have instances where testIDs are not consistently stored in variables. This lack of uniformity can lead to redundant testID declarations throughout the codebase, resulting in code that is harder to maintain and prone to errors.
A more effective and best-practice approach is to store the testID value as a variable and then reference that variable when defining the testID property. By doing so, we centralize the testID values, reducing redundancy and making it easier to manage and maintain these identifiers throughout the codebase. This approach enhances code consistency and reduces the likelihood of introducing errors, ultimately contributing to a more robust and maintainable codebase.
Related issues
Fixes: #
Manual testing steps
Screenshots/Recordings
Before
After
Smoke E2E test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c081b66c-78d1-4ec0-8bde-d0e83389855b
Regression E2E test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fc4ec84f-6c1a-4655-b67b-31d69c972ac0
Pre-merge author checklist
Pre-merge reviewer checklist