Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick: test: Increase E2E test setup time (#7929) #7977

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

chrisleewilcox
Copy link
Contributor

Description

The android E2E tests have encountered failures because the installation of the application on the emulator now takes longer than the current test timeout allows. In order to restore the ability to pass the E2E tests, the purpose of this pull request (PR) is to increase the test setup time, allowing sufficient time for the installation process.

Before

Failing Bitrise builds:

https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fa0431b0-3114-4a0f-a511-23d065d4d244

https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/10be074e-af5f-4750-8d72-7e61c6102b9d

https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fa0431b0-3114-4a0f-a511-23d065d4d244

After

Passing bitrise smoke Build:
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/354f2ad1-121b-4f48-9d7d-479bcb00160d Passing bitrise regression test build:
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/354f2ad1-121b-4f48-9d7d-479bcb00160d

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Related issues

Fixes: #

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description**

The android E2E tests have encountered failures because the installation
of the application on the emulator now takes longer than the current
test timeout allows. In order to restore the ability to pass the E2E
tests, the purpose of this pull request (PR) is to increase the test
setup time, allowing sufficient time for the installation process.


### **Before**

Failing Bitrise builds: 

https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fa0431b0-3114-4a0f-a511-23d065d4d244

https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/10be074e-af5f-4750-8d72-7e61c6102b9d

https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fa0431b0-3114-4a0f-a511-23d065d4d244


### **After**


Passing bitrise smoke Build:
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/354f2ad1-121b-4f48-9d7d-479bcb00160d
Passing bitrise regression test build:
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/354f2ad1-121b-4f48-9d7d-479bcb00160d

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@chrisleewilcox chrisleewilcox added team-mobile-client release-7.12.0 Issue or pull request that will be included in release 7.12.0 labels Dec 1, 2023
@chrisleewilcox chrisleewilcox self-assigned this Dec 1, 2023
@chrisleewilcox chrisleewilcox changed the title test: Increase E2E test setup time (#7929) chore: cherry-pick: test: Increase E2E test setup time (#7929) Dec 1, 2023
@chrisleewilcox chrisleewilcox marked this pull request as ready for review December 1, 2023 15:15
@chrisleewilcox chrisleewilcox requested a review from a team as a code owner December 1, 2023 15:15
Copy link
Contributor

github-actions bot commented Dec 1, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0386f496-8227-46df-b60f-a79f173bbafe
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@chrisleewilcox chrisleewilcox merged commit c38e083 into release/7.12.0 Dec 1, 2023
31 checks passed
@chrisleewilcox chrisleewilcox deleted the chore/cherry-pick-7292-android-fix branch December 1, 2023 17:49
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants