-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Content update for Swaps #7960
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dan437 this PR will need to comply with all the formalities for mobile. Please address audit issues and apply the 'Run Smoke E2E' label to kick-off automated smoke tests. This change may also break our swaps tests and we would like to have that adjusted with this change before merging. Once that is all done then reviewing this should be a breeze.
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/217f2d7a-73a8-40c2-8944-4ccd637ba65a |
ac9f1fc
to
b3376d0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7960 +/- ##
==========================================
- Coverage 36.66% 36.64% -0.02%
==========================================
Files 1090 1090
Lines 29115 29113 -2
Branches 2668 2668
==========================================
- Hits 10674 10668 -6
- Misses 17835 17839 +4
Partials 606 606 ☔ View full report in Codecov by Sentry. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/29f20a96-1234-4cab-8387-66c6d7b36a8b |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0828a8f4-27b9-4e79-8252-761922396689 |
@dan437 the swaps tests failed on the onboarding modal. Is this the modal that is not expected to show with these changes? You can see the screenshot taking on the failed tests in the bitrise link. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/55c13ee2-fe5f-42b7-a95f-473586f188e4 |
Kudos, SonarCloud Quality Gate passed! |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/05e884a3-62a5-40d0-be84-88bd141fd122 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Use a simplified copy for clarity and readability in Swaps, as we do in the extension. We have also decided to hide the intro modal in Swaps for now. We will enable it once we have an updated UI and content for it.
Screenshots/Recordings