Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Content update for Swaps #7960

Merged
merged 7 commits into from
Dec 1, 2023
Merged

feat: Content update for Swaps #7960

merged 7 commits into from
Dec 1, 2023

Conversation

dan437
Copy link
Contributor

@dan437 dan437 commented Nov 30, 2023

Description

Use a simplified copy for clarity and readability in Swaps, as we do in the extension. We have also decided to hide the intro modal in Swaps for now. We will enable it once we have an updated UI and content for it.

Screenshots/Recordings

image

image

@dan437 dan437 requested a review from a team as a code owner November 30, 2023 15:16
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 30, 2023
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dan437 this PR will need to comply with all the formalities for mobile. Please address audit issues and apply the 'Run Smoke E2E' label to kick-off automated smoke tests. This change may also break our swaps tests and we would like to have that adjusted with this change before merging. Once that is all done then reviewing this should be a breeze.

@dan437 dan437 added Run Smoke E2E release-7.13.0 Issue or pull request that will be included in release 7.13.0 labels Nov 30, 2023
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/217f2d7a-73a8-40c2-8944-4ccd637ba65a
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@dan437 dan437 changed the title Content update for Swaps feat: Content update for Swaps Nov 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (195a534) 36.66% compared to head (a8f6264) 36.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7960      +/-   ##
==========================================
- Coverage   36.66%   36.64%   -0.02%     
==========================================
  Files        1090     1090              
  Lines       29115    29113       -2     
  Branches     2668     2668              
==========================================
- Hits        10674    10668       -6     
- Misses      17835    17839       +4     
  Partials      606      606              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/29f20a96-1234-4cab-8387-66c6d7b36a8b
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0828a8f4-27b9-4e79-8252-761922396689
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@chrisleewilcox
Copy link
Contributor

@dan437 the swaps tests failed on the onboarding modal. Is this the modal that is not expected to show with these changes? You can see the screenshot taking on the failed tests in the bitrise link.
testFnFailure

Copy link
Contributor

github-actions bot commented Dec 1, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/55c13ee2-fe5f-42b7-a95f-473586f188e4
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

github-actions bot commented Dec 1, 2023

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/05e884a3-62a5-40d0-be84-88bd141fd122
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@forest-diggs-consensys forest-diggs-consensys merged commit 196ebc5 into main Dec 1, 2023
29 checks passed
@forest-diggs-consensys forest-diggs-consensys deleted the swaps-content branch December 1, 2023 03:12
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2023
@metamaskbot metamaskbot added the release-7.14.0 Issue or pull request that will be included in release 7.14.0 label Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-7.13.0 Issue or pull request that will be included in release 7.13.0 release-7.14.0 Issue or pull request that will be included in release 7.14.0 team-swaps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants