Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bitrise cocoapods issue in bitrise #7935

Merged
merged 36 commits into from
Nov 29, 2023
Merged

Conversation

Andepande
Copy link
Member

@Andepande Andepande commented Nov 28, 2023

Description

The Bitrise failure was due to a lacking version of ruby on the Mac machines that was deprecated on 11/24. This PR bumps the ruby version to 3.0.0.

Related issues

Fixes: #

Manual testing steps

Screenshots/Recordings

Before

After

Bitrise E2E

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Andepande Andepande added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-client labels Nov 28, 2023
@Andepande Andepande requested a review from a team as a code owner November 28, 2023 15:14
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (51199b5) 37.44% compared to head (825b51c) 37.46%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7935      +/-   ##
==========================================
+ Coverage   37.44%   37.46%   +0.02%     
==========================================
  Files        1052     1052              
  Lines       28192    28202      +10     
  Branches     2517     2517              
==========================================
+ Hits        10556    10566      +10     
  Misses      17037    17037              
  Partials      599      599              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sethkfman sethkfman changed the title fix: re-fix bitrise cocoapods issue in bitrise fix: bitrise cocoapods issue in bitrise Nov 29, 2023
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisleewilcox chrisleewilcox merged commit 7b76904 into main Nov 29, 2023
28 checks passed
@chrisleewilcox chrisleewilcox deleted the bitrise-fix-re-run branch November 29, 2023 02:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2023
@metamaskbot metamaskbot added the release-7.13.0 Issue or pull request that will be included in release 7.13.0 label Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.13.0 Issue or pull request that will be included in release 7.13.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants