-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Prevent SES errors in iOS dev builds #7924
Conversation
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/28594618-dbbb-4655-ad9d-4e04e761ccd6 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7924 +/- ##
=======================================
Coverage 37.39% 37.39%
=======================================
Files 1052 1052
Lines 28175 28175
Branches 2517 2517
=======================================
Hits 10536 10536
Misses 17040 17040
Partials 599 599 ☔ View full report in Codecov by Sentry. |
SES is now disabled in development builds. This was done as a workaround to various incompatibilities between SES and React development libraries, which were causing a SES error whenever a warning or error was triggered in an iOS dev build. Fixes #7923
ea01697
to
50d7065
Compare
Kudos, SonarCloud Quality Gate passed! |
tested in-app (metamask.github.io/test-dapp) on 69c79df before: after: |
Description
SES is now disabled in development builds. This was done as a workaround to various incompatibilities between SES and React development libraries, which were causing a SES error whenever a warning or error was triggered in an iOS dev build.
Related issues
Fixes #7923
Manual testing steps
Follow the reproduction steps for this issue: #7920
Screenshots/Recordings
Before:
After:
Pre-merge author checklist
Pre-merge reviewer checklist