Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: android sdk connectsign + batch request #7921

Merged
merged 27 commits into from
Nov 30, 2023

Conversation

abretonc7s
Copy link
Contributor

@abretonc7s abretonc7s commented Nov 23, 2023

Description

Related issues

Fixes: #

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

Attention: 375 lines in your changes are missing coverage. Please review.

Comparison is base (7b76904) 37.46% compared to head (45648df) 36.58%.
Report is 6 commits behind head on main.

Files Patch % Lines
.../core/SDKConnect/handlers/handleConnectionReady.ts 1.69% 58 Missing ⚠️
app/core/SDKConnect/AndroidSDK/AndroidService.ts 0.00% 42 Missing ⚠️
app/core/SDKConnect/SDKConnect.ts 0.00% 41 Missing ⚠️
app/core/SDKConnect/handlers/handleSendMessage.ts 2.56% 38 Missing ⚠️
...ore/SDKConnect/handlers/handleConnectionMessage.ts 2.70% 36 Missing ⚠️
...p/core/SDKConnect/handlers/handleCustomRpcCalls.ts 2.85% 34 Missing ⚠️
app/core/SDKConnect/handlers/checkPermissions.ts 3.33% 29 Missing ⚠️
...core/SDKConnect/handlers/handleBatchRpcResponse.ts 3.57% 27 Missing ⚠️
app/core/SDKConnect/Connection.ts 0.00% 25 Missing ⚠️
app/core/SDKConnect/handlers/setupBridge.ts 5.26% 18 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7921      +/-   ##
==========================================
- Coverage   37.46%   36.58%   -0.89%     
==========================================
  Files        1052     1082      +30     
  Lines       28202    29053     +851     
  Branches     2517     2653     +136     
==========================================
+ Hits        10566    10628      +62     
- Misses      17037    17827     +790     
+ Partials      599      598       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christopherferreira9 christopherferreira9 added team-sdk SDK team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Nov 24, 2023
@abretonc7s abretonc7s marked this pull request as ready for review November 24, 2023 09:37
@abretonc7s abretonc7s requested a review from a team as a code owner November 24, 2023 09:37
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/894a5c2d-56b7-41b3-a5e0-d5f884805c26
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

omridan159
omridan159 previously approved these changes Nov 24, 2023
@abretonc7s abretonc7s force-pushed the feat/android-connectsign branch from e0c4bdf to 44d651e Compare November 29, 2023 11:59
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

1.8% 1.8% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherferreira9
Copy link
Contributor

LGTM!
Test cases and run can be found under the SDK documentation as this involved a full regression over the multiple SDKs.

@christopherferreira9 christopherferreira9 merged commit 728ed44 into main Nov 30, 2023
26 checks passed
@christopherferreira9 christopherferreira9 deleted the feat/android-connectsign branch November 30, 2023 13:44
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
@christopherferreira9
Copy link
Contributor

@metamaskbot metamaskbot added the release-7.13.0 Issue or pull request that will be included in release 7.13.0 label Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.13.0 Issue or pull request that will be included in release 7.13.0 team-sdk SDK team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants