fix: 7862 invalid address error

[dawnseeker8]

Description

This PR was created to fix the issue [#7862], following code change has been done:

1. Change the getKeyringByAddress() method to return undefined when address is not valid hex address (e.g. ENS domain name)
2. Fix the existing unit tests to reflect above changes in address/index.test.ts file
3. add extra unit tests to make sure function will return undefined when address is not valid hex address (e.g. ENS domain)

Related issues

Fixes: [#7862]

Manual testing steps

Please refer to following videos for detail how to test.

Screenshots/Recordings

Before

before.mp4

After

Screen_Recording_20231120_224005_MetaMask.mp4

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4e01d6e) 37.42% compared to head (eb47326) 37.38%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7881      +/-   ##
==========================================
- Coverage   37.42%   37.38%   -0.04%     
==========================================
  Files        1052     1052              
  Lines       28177    28177              
  Branches     2516     2516              
==========================================
- Hits        10544    10534      -10     
- Misses      17034    17044      +10     
  Partials      599      599              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f1bdb212-c238-4106-9754-7496f5231bef
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

[cryptotavares]

@dawnseeker8 can you please also add a unit test to the AddressInput component where the toSelectedAddress is not a valid hex address?
AddressTo Component
Existing unit tests - as you can see there are only tests with valid hex addresses.

[seaona]

The PR looks good from QA cc @dawnseeker8 . I see the issue fixed. I can enter any char, and both hex and ENS address seem to work as expected

recipietn-to-char.mp4

[sethkfman]

LGTM

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication