-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove unused .tools-versions to prioritize nvm #7838
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/20d8df9a-b10c-4052-ab06-e67db89f4074 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7838 +/- ##
=======================================
Coverage 35.04% 35.04%
=======================================
Files 1040 1040
Lines 27710 27710
Branches 2344 2344
=======================================
Hits 9711 9711
Misses 17475 17475
Partials 524 524 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8496601b-a9a7-4642-be45-2f7d663cf98f |
Kudos, SonarCloud Quality Gate passed! |
Description
Cleanup asdf config file to prioritise nvm as node manager.
Related issues
Fixes: #
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist