fix android builds: update hermes commit hash

[jpcloureiro]

Description

Patch file update breaks GH diff. Line 92 is the only change made.

-def hermesVersion = "ae2ac688c3faf868d2360a10a7791226ed5702fb"
+def hermesVersion = "52725e889185e53277e629f1f7043aa2913c97a9"

android build fails with xcode 15 command line tools.

node_modules/react-native/sdks/hermes/lib/Support/Semaphore.cpp:35:3: error: use of undeclared identifier 'assert'
  assert(semPtr_ != nullptr && "sem_open should have succeeded");
  ^
1 error generated.
make[3]: *** [lib/Support/CMakeFiles/hermesSupport.dir/Semaphore.cpp.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [lib/Support/CMakeFiles/hermesSupport.dir/all] Error 2
make[1]: *** [tools/hermesc/CMakeFiles/hermesc.dir/rule] Error 2
make: *** [hermesc] Error 2

#include <cassert> is needed to bring assert implementation

See changes on our hermes fork
MetaMask/hermes@52725e8

Related issues

Fixes: #

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[leotm]

ah thought i was the only one!
originally ran into this ~1mo ago on Xcode 14.2 thinking it was SES
then realising it's happening locally too on main - but CI somehow passing?
so till now been bypassing our custom build locally as temp fix

android build fails with xcode 15 command line tools.

so can confirm was happening on xcode 14 cli tools too

still not 100% what the exact cause was 1 month ago if you have a better idea

but the fix makes sense, thanks for tackling this

and wondering what we can do to anticipate our custom fork breaking android in future

[chrisleewilcox]

@jpcloureiro I was able to build android locally using yarn start:android from this branch.

LGTM

[github-actions]

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c0b4ec1b-a317-4cc9-b53e-e9d19443377a
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label