-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable ledger hardware wallet implementation. #7757
Conversation
context will not able to pass in to defaultProps, hence default translation should apply into the component itself
…feat/ledger-enable
…l' into feat/ledger-enable
…nto feat/ledger-enable
This commit didnt contain the unit tests code.
also remove duplicate unit tests.
This change hides the ledger feature behind an experimental flag.
… breank ios build.
Kudos, SonarCloud Quality Gate passed! |
This is the latest smoke e2e tests result https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/74ad83d1-aaea-4065-935b-2d6c220e5d0d |
This is the latest regression e2e tests result: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4553befb-80f7-4c38-883b-7e9a95d6943a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've manually tested the PR and verified the test cases
I've manually tested the PR and verified the test cases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as @brianacnguyen previously mentioned no updates to component-library folder
Description
The PR enable ledger hardware wallet support in Metamask mobiles.
Ledger pre-requisite:
keyring controller
to allow exposingEthKeyringController
to support ledger keyring operationapp/core/Ledger/Ledger.ts
to support ledger operation, such asadd ledger, remove ledger, unlock ledger account, get ledger, connect ledger, open ledger app and close ledger app
Permission-BluetoothPeripheral
in IOS pod@consensys/ledgerhq-metamask-keyring
@ledgerhq/react-native-hw-transport-ble
andreact-native-ble-plx
Enable ledger features:
eth_sign
personal_sign
eth_signTypedDataV4
REQUEST_SEND
,COMPLETE
,ERROR
] in RPCMethodMiddleware to support ledger sign modal interactionaccount_type
metrics for swap operation and account connect componentExtendedKeyringTypes
to consolidate the keyring type from keyring controller and ledgerfontSize
andfontWeight
withTextVariant
on account label tag related components to adopt theme designRelated issues
Fixes: #1237
Manual testing steps
Need a full regression tests to test all ledger relative feature using https://metamask.github.io/test-dapp/
Screenshots/Recordings
For detailed of screenshot, please refer to our internal Figma design. we will only list out some screenshot below:
Scan devices
Pair with ledger
Transfer
Sign message:
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist