-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert: undo QR code changes from previous merge #7749
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7749 +/- ##
=======================================
Coverage 35.09% 35.09%
=======================================
Files 1035 1035
Lines 27523 27523
Branches 2312 2312
=======================================
Hits 9658 9658
Misses 17345 17345
Partials 520 520
☔ View full report in Codecov by Sentry. |
Could you provide a video showing this scenario is fixed? https://consensys.slack.com/archives/C02U025CVU4/p1699532816609679 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Description
This hotfix reverts an intended fix for related issue below
Related issues
Fixes: #942
Manual testing steps
Screenshots/Recordings
Before
After
Video of scan of QR code with original crash on scan:
Screen_Recording_20231110_012216_MetaMask.mp4
Scan of QR code from Omri:
Screen_Recording_20231111_003601_MetaMask.mp4
Pre-merge author checklist
Pre-merge reviewer checklist