-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable code fence capabilities on mobile app. #7734
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
we also need to ensure that we run a lint step after we build both main and flask to ensure that there are no unused variables and that each |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ad77009b-f443-4b42-a895-4d366242bf26 |
@Jonathansoufer The only thing I would add is a bit of documentation in the README.md with a short description of code fencing and how to use it. If you wrote something up in notion bring it into the project. |
@Jonathansoufer we can probably add a similar readme to this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7734 +/- ##
==========================================
+ Coverage 35.17% 35.32% +0.15%
==========================================
Files 1039 1040 +1
Lines 27614 27714 +100
Branches 2340 2340
==========================================
+ Hits 9712 9789 +77
- Misses 17377 17400 +23
Partials 525 525 ☔ View full report in Codecov by Sentry. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bc01b80b-4ace-4f58-a81e-aebf855ad731 |
b61170b
to
79e727c
Compare
…rence in a ReadMe
- METAMASK_BUILD_TYPE can either be 'main' or 'flask' - All instances of METAMASK_BUILD_TYPE should be set to 'main' for now. Flask will be introduced later.
2c03921
to
9abd279
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
the pr regression e2e also passed: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4967eb2b-de95-42d7-af15-7041d7f07647 |
Kudos, SonarCloud Quality Gate passed! |
Description
This PR implements code fence feature to allow flask and main code co-live in the same branch yet delivered accordantly with build type, meaning flask code will only be included in flask build and not main.
Here is the version of code fencing implemented on extension.
Related issues
Fixes: https://github.com/MetaMask/accounts-planning/issues/112
Manual testing steps
Add code fence directive (BEGIN and END) on any code block and run the build.
Pre-merge author checklist
Pre-merge reviewer checklist
Next Steps
android/app/build.gradle
and add new iOS configurations/schemas for FLASK build.