Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Deprecate SheetBottom component #7657

Merged
merged 4 commits into from
Nov 8, 2023
Merged

feat: Deprecate SheetBottom component #7657

merged 4 commits into from
Nov 8, 2023

Conversation

tommasini
Copy link
Contributor

Description

Deprecating SheetBottom component, for developers use the BottomSheet instead.

Related issues

Fixes: #

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-client labels Oct 31, 2023
@tommasini tommasini requested a review from a team as a code owner October 31, 2023 23:17
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 31, 2023
@github-actions GitHub Actions
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6d2166c9-47ad-466b-9ce8-fe0efe888539
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f20b42b) 34.98% compared to head (1a283b3) 34.98%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7657   +/-   ##
=======================================
  Coverage   34.98%   34.98%           
=======================================
  Files        1030     1030           
  Lines       27376    27376           
  Branches     2253     2253           
=======================================
  Hits         9577     9577           
  Misses      17289    17289           
  Partials      510      510
Files Coverage Δ
...brary/components/Sheet/SheetBottom/SheetBottom.tsx 60.75% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

georgewrmarshall
georgewrmarshall reviewed Nov 1, 2023
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! Made one suggestion

  • Pulled branch and checked deprecated formatting works ✅

Screenshot 2023-10-31 at 6 27 19 PM

app/component-library/components/Sheet/SheetBottom/SheetBottom.tsx Outdated Show resolved Hide resolved
Cal-L
Cal-L approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tommasini tommasini merged commit bdcadc0 into main Nov 8, 2023
25 checks passed
@tommasini tommasini deleted the fix/deprecate-sheet-bottom-comp branch November 8, 2023 11:29
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 8, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

Assignees
No one assigned
Labels
release-7.12.0 Issue or pull request that will be included in release 7.12.0 Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tommasini @codecov-commenter @georgewrmarshall @Cal-L @gauthierpetetin @metamaskbot