Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test:7562 move testids settings folder #7650

Merged
merged 8 commits into from
Nov 1, 2023

Conversation

SamuelSalas
Copy link
Contributor

Description

Relocate the TestIDs from each page object to their corresponding testID file within the testID folder. This task is aimed at transferring the TestIDs from the page objects in the settings folder.

Related issues

Fixes: #7562

Manual testing steps

Screenshots/Recordings

WebdriverIO test run https://app.bitrise.io/build/50acb604-97ef-4fd2-83f6-6ea3734a1e94
Detox test run https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f0edde54-b2b0-4e80-8b2b-76b00ea6e813

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@SamuelSalas SamuelSalas added the type-tech-debt Technical debt label Oct 31, 2023
@SamuelSalas SamuelSalas self-assigned this Oct 31, 2023
@SamuelSalas SamuelSalas requested a review from a team as a code owner October 31, 2023 02:05
@SamuelSalas SamuelSalas linked an issue Oct 31, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/aebc197a-2852-4f05-83ec-bb5f4d221334
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@SamuelSalas SamuelSalas changed the title Test/7562 move testids settings folder test:7562 move testids settings folder Oct 31, 2023
@metamaskbot metamaskbot added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 31, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f20b42b) 34.98% compared to head (f22f87f) 34.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7650      +/-   ##
==========================================
- Coverage   34.98%   34.95%   -0.04%     
==========================================
  Files        1030     1030              
  Lines       27376    27363      -13     
  Branches     2253     2253              
==========================================
- Hits         9577     9564      -13     
  Misses      17289    17289              
  Partials      510      510              
Files Coverage Δ
app/components/UI/AddCustomNetwork/index.js 62.50% <ø> (ø)
app/components/Views/Login/index.js 9.09% <ø> (ø)
...omponents/Views/Settings/AdvancedSettings/index.js 63.51% <ø> (ø)
...Settings/NetworksSettings/NetworkSettings/index.js 2.64% <ø> (ø)
...ettings/Sections/ChangePassword/ChangePassword.tsx 85.71% <ø> (ø)
...s/Sections/ProtectYourWallet/ProtectYourWallet.tsx 52.38% <ø> (ø)
...ews/Settings/SecuritySettings/SecuritySettings.tsx 51.55% <ø> (ø)
app/constants/test-ids.js 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments

@SamuelSalas SamuelSalas requested a review from cortisiko October 31, 2023 22:23
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ ✅ ✅ ✅

Copy link
Member

@Andepande Andepande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SamuelSalas SamuelSalas merged commit b20820b into main Nov 1, 2023
25 checks passed
@SamuelSalas SamuelSalas deleted the test/7562-move-testids-settings-folder branch November 1, 2023 16:04
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 1, 2023
@metamaskbot metamaskbot added the release-7.11.0 Issue or pull request that will be included in release 7.11.0 label Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.11.0 Issue or pull request that will be included in release 7.11.0 team-mobile-platform type-tech-debt Technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move TestIDs from page objects in Settings folder
6 participants