-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test:7562 move testids settings folder #7650
Conversation
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/aebc197a-2852-4f05-83ec-bb5f4d221334 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7650 +/- ##
==========================================
- Coverage 34.98% 34.95% -0.04%
==========================================
Files 1030 1030
Lines 27376 27363 -13
Branches 2253 2253
==========================================
- Hits 9577 9564 -13
Misses 17289 17289
Partials 510 510
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few comments
…ect. SettingsView selectors file created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ ✅ ✅ ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
Relocate the TestIDs from each page object to their corresponding testID file within the testID folder. This task is aimed at transferring the TestIDs from the page objects in the settings folder.
Related issues
Fixes: #7562
Manual testing steps
Screenshots/Recordings
WebdriverIO test run https://app.bitrise.io/build/50acb604-97ef-4fd2-83f6-6ea3734a1e94
Detox test run https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f0edde54-b2b0-4e80-8b2b-76b00ea6e813
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist