-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move spec files to subfolders #7635
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b59b8dd7-03ef-4559-ac4b-1695d7443b48 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Only left one minor comment
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7635 +/- ##
=======================================
Coverage 34.99% 34.99%
=======================================
Files 1030 1030
Lines 27385 27385
Branches 2253 2253
=======================================
Hits 9583 9583
Misses 17292 17292
Partials 510 510 ☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Maybe as a follow-up task, we move all the failing/broken tests into a quarantine folder.
Description
See issue #1213
Related issues
Fixes: #
Manual testing steps
Trigger any of the tests workflows in bitrise and they should continue to pass.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist