Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move spec files to subfolders #7635

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Conversation

chrisleewilcox
Copy link
Contributor

@chrisleewilcox chrisleewilcox commented Oct 27, 2023

Description

See issue #1213

Related issues

Fixes: #

Manual testing steps

Trigger any of the tests workflows in bitrise and they should continue to pass.

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@chrisleewilcox chrisleewilcox requested a review from a team as a code owner October 27, 2023 15:49
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chrisleewilcox chrisleewilcox added tests Test related issues needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-client labels Oct 27, 2023
@github-actions
Copy link
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b59b8dd7-03ef-4559-ac4b-1695d7443b48
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@chrisleewilcox chrisleewilcox added No QA Needed Apply this label when your PR does not need any QA effort. and removed Run Smoke E2E labels Oct 27, 2023
cortisiko
cortisiko previously approved these changes Oct 27, 2023
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only left one minor comment

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1bb735) 34.99% compared to head (07a953f) 34.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7635   +/-   ##
=======================================
  Coverage   34.99%   34.99%           
=======================================
  Files        1030     1030           
  Lines       27385    27385           
  Branches     2253     2253           
=======================================
  Hits         9583     9583           
  Misses      17292    17292           
  Partials      510      510           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe as a follow-up task, we move all the failing/broken tests into a quarantine folder.

@chrisleewilcox chrisleewilcox merged commit 6e1035d into main Oct 27, 2023
25 checks passed
@chrisleewilcox chrisleewilcox deleted the detox-restructure-tests branch October 27, 2023 18:33
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 27, 2023
@metamaskbot metamaskbot added the release-7.11.0 Issue or pull request that will be included in release 7.11.0 label Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.11.0 Issue or pull request that will be included in release 7.11.0 team-mobile-platform tests Test related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants